alamb commented on issue #4495: URL: https://github.com/apache/arrow-datafusion/issues/4495#issuecomment-1407625555
> Are there any guidelines for using or not using rowsort and order by in Datafusion? @melgenek -- thank you raising this question; The use of `rowsort` vs `order by` I think depends on what the test is testing. In my view, if the test might be changed due to the fact there is a sort / order by on it (due to a different codepath for example) then `rowsort` should be used. If the ordering doesn't change the meaning of the test then `order by` is fine I think in most cases, adding `order by` is probably just fine, but to maintain the semantics of existing tests I would probably default to using `rowsort` initially rather than changing the queries in the test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
