viirya commented on code in PR #3621:
URL: https://github.com/apache/arrow-rs/pull/3621#discussion_r1090028189
##########
arrow-data/src/bit_iterator.rs:
##########
@@ -186,14 +186,7 @@ pub fn try_for_each_valid_idx<E, F: FnMut(usize) ->
Result<(), E>>(
if valid_count == len {
(0..len).try_for_each(f)
} else if null_count != len {
- let selectivity = valid_count as f64 / len as f64;
- if selectivity > 0.8 {
- BitSliceIterator::new(nulls.unwrap(), offset, len)
- .flat_map(|(start, end)| start..end)
- .try_for_each(f)
Review Comment:
Yea, I think this won't be vectorized due to fallible op.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
