pitrou commented on code in PR #14293:
URL: https://github.com/apache/arrow/pull/14293#discussion_r1090423379
##########
cpp/src/parquet/encoding.cc:
##########
@@ -3137,15 +3308,14 @@ std::unique_ptr<Decoder> MakeDecoder(Type::type
type_num, Encoding::type encodin
default:
throw ParquetException(
"DELTA_BINARY_PACKED decoder only supports INT32 and INT64");
- break;
}
} else if (encoding == Encoding::DELTA_BYTE_ARRAY) {
if (type_num == Type::BYTE_ARRAY) {
return std::make_unique<DeltaByteArrayDecoder>(descr);
}
throw ParquetException("DELTA_BYTE_ARRAY only supports BYTE_ARRAY");
} else if (encoding == Encoding::DELTA_LENGTH_BYTE_ARRAY) {
- if (type_num == Type::BYTE_ARRAY) {
+ if (type_num == Type::BYTE_ARRAY || type_num ==
Type::FIXED_LEN_BYTE_ARRAY) {
Review Comment:
This may seem like an artificial limitation, but only BYTE_ARRAY is
supported according to
https://github.com/apache/parquet-format/blob/master/Encodings.md#delta-length-byte-array-delta_length_byte_array--6.
Perhaps you can take a look at what parquet-mr does?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
