lukester1975 commented on issue #15098: URL: https://github.com/apache/arrow/issues/15098#issuecomment-1408376316
Spent a little more time on this. There are various problems with dependencies with a simple addition of a clang-cl environment: * The boost `Unknown toolset: vcunk` issue is simply that boost 1.75.0 predates VS2022 so doesn't know about the vc143 toolset. * Whilst `BOOST_SOURCE_URL` can be set from the environment's `ARROW_BOOST_URL`, it just fails sha validation after download since `ARROW_BOOST_BUILD_SHA256_CHECKSUM` is (only?) read from `versions.txt`. * Not sure if that's an oversight or there's some other way to specify a boost version (there's a lot going on there...) but I modded `versions.txt` to use boost 1.79.0 with the appropriate sha and it that works. * Next up is a weird protobuf resource file issue: https://github.com/lukester1975/arrow/actions/runs/4038346404/jobs/6942758428#step:11:1088, so added a patch to only set `/bigobj` with cl, not clang-cl (it's implicit there anyway). * Next is snappy just not being aware of clang-cl: https://github.com/google/snappy/pull/152, so patch similarly. * Then orc fails to build, so just turned that off. * Thrift then fails with errors about exceptions disabled, even though I can't see any `/EH` switches: https://github.com/lukester1975/arrow/actions/runs/4042546242/jobs/6950376636#step:11:1106 At that point I'm stopping, not something I can spend more time on. The changes are here: https://github.com/lukester1975/arrow/tree/add-vs2022-clang-cl I made a branch with the fix for the actual issue I was reporting. All green: https://github.com/lukester1975/arrow/actions?query=branch%3Afix-clang-cl-c%2B%2B20 Maybe you could consider merging it and adding a CI job to simply attempt to compile the trivial main with clang-cl? Sounds like fixing the whole dependency tree to compile with clang-cl is a lot of work... Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
