tustvold commented on code in PR #5113:
URL: https://github.com/apache/arrow-datafusion/pull/5113#discussion_r1090688811
##########
datafusion/proto/src/logical_plan/from_proto.rs:
##########
@@ -1389,7 +1415,7 @@ pub fn from_proto_binary_op(op: &str) -> Result<Operator,
Error> {
}
fn parse_optional_expr(
- p: &Option<Box<protobuf::LogicalExprNode>>,
+ p: Option<Box<protobuf::LogicalExprNode>>,
Review Comment:
```suggestion
p: Option<&protobuf::LogicalExprNode>,
```
##########
datafusion/proto/src/logical_plan/from_proto.rs:
##########
@@ -1399,7 +1425,7 @@ fn parse_optional_expr(
}
fn parse_required_expr(
- p: &Option<Box<protobuf::LogicalExprNode>>,
+ p: Option<Box<protobuf::LogicalExprNode>>,
Review Comment:
```suggestion
p: Option<&protobuf::LogicalExprNode>,
```
##########
datafusion/proto/src/logical_plan/from_proto.rs:
##########
@@ -876,7 +876,7 @@ pub fn parse_expr(
.ok_or_else(|| Error::required("value"))?
.try_into()?;
- let expr = parse_required_expr(&field.expr, registry, "expr")?;
+ let expr = parse_required_expr(field.expr.clone(), registry,
"expr")?;
Review Comment:
```suggestion
let expr = parse_required_expr(field.expr.as_deref(), registry,
"expr")?;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
