felipecrv commented on code in PR #33938:
URL: https://github.com/apache/arrow/pull/33938#discussion_r1091176523
##########
cpp/src/arrow/visitor_generate.h:
##########
@@ -65,4 +65,50 @@ namespace arrow {
ACTION(Dictionary); \
ACTION(Extension)
+#define ARROW_GENERATE_FOR_ALL_INTEGER_TYPES2(ACTION, ARG1) \
+ ACTION(Int8, ARG1); \
+ ACTION(UInt8, ARG1); \
+ ACTION(Int16, ARG1); \
+ ACTION(UInt16, ARG1); \
+ ACTION(Int32, ARG1); \
+ ACTION(UInt32, ARG1); \
+ ACTION(Int64, ARG1); \
+ ACTION(UInt64, ARG1)
+
+#define ARROW_GENERATE_FOR_ALL_NUMERIC_TYPES2(ACTION, ARG1) \
+ ARROW_GENERATE_FOR_ALL_INTEGER_TYPES2(ACTION, ARG1); \
+ ACTION(HalfFloat, ARG1); \
+ ACTION(Float, ARG1); \
+ ACTION(Double, ARG1)
+
+#define ARROW_GENERATE_FOR_ALL_TYPES2(ACTION, ARG1) \
Review Comment:
There were some changes in this file since I did this and there's a better
approach I can take that doesn't need these new lines here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
