westonpace opened a new pull request, #33940: URL: https://github.com/apache/arrow/pull/33940
If you have an equality operator then C++20 would now like it to be symmetric (at least on clang). The util::EqualityComparable operator== was defined as: `bool operator==(util::EqualityComparable<T>, T)` and there is no equivalent: `bool operator==(T, util::EqualityComparable<T>)` Some more discussion on this is at: https://bugzilla.redhat.com/show_bug.cgi?id=1874364 Furthermore, the old definition allowed for `Scalar::operator==(std::shared_ptr<Scalar> other)` (i.e. comparing with a shared_ptr) and it isn't clear to me that should be allowed (it's generally inconsistent with the rest of the code base). This change seems to have undone that and I made no change to restore it (and instead fixed the references to that odd equality operation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
