rok commented on PR #33731: URL: https://github.com/apache/arrow/pull/33731#issuecomment-1409495238
> On one hand that would capture allocations not in the memory pool, which is nice. On the other hand, it means we are looking at the memory pool's requests for allocations, which might make the metrics less useful, since they are the allocations we have less direct control over and may even be non-deterministic (especially other benchmarks can become noisy neighbors). Indeed, that would make this proposal more of a "unit benchmark" and jemalloc alternative an "integration benchmark". I do think the current proposal is more useful for developers. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
