pitrou commented on code in PR #33641:
URL: https://github.com/apache/arrow/pull/33641#discussion_r1091674353
##########
cpp/src/arrow/array/data.cc:
##########
@@ -195,6 +195,7 @@ int GetNumBuffers(const DataType& type) {
case Type::NA:
case Type::STRUCT:
case Type::FIXED_SIZE_LIST:
+ case Type::RUN_END_ENCODED:
return 1;
Review Comment:
We shouldn't deviate from established practice on other datatypes.
* `IsValid` on `DictionaryArray` only queries the indices, not the
dictionary values
* `IsValid` on `UnionArray` already returns false, even if the corresponding
child entry is null
Also you'll notice that `IsValid` and `IsNull` are non-virtual methods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
