pitrou commented on code in PR #24372:
URL: https://github.com/apache/arrow/pull/24372#discussion_r1091771388
##########
cpp/src/arrow/array/builder_base.h:
##########
@@ -145,6 +168,11 @@ class ARROW_EXPORT ArrayBuilder {
virtual Status AppendScalar(const Scalar& scalar, int64_t n_repeats);
virtual Status AppendScalars(const ScalarVector& scalars);
+ /// \brief Append a scalar value from an optional or null if it has no value.
Review Comment:
I think you misunderstood my comment. "from an optional" is wrong: there is
no optional here, just a shared_ptr that might be null.
Also, TBH, I'm not sure I understand the point of this API. Are there
situations where this would be useful?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
