felipecrv commented on code in PR #24372:
URL: https://github.com/apache/arrow/pull/24372#discussion_r1091898812


##########
cpp/src/arrow/array/builder_base.h:
##########
@@ -145,6 +168,11 @@ class ARROW_EXPORT ArrayBuilder {
   virtual Status AppendScalar(const Scalar& scalar, int64_t n_repeats);
   virtual Status AppendScalars(const ScalarVector& scalars);
 
+  /// \brief Append a scalar value from an optional or null if it has no value.

Review Comment:
   Oh right. The comment on this one shouldn't be like the others.
   
   > Also, TBH, I'm not sure I understand the point of this API. Are there 
situations where this would be useful?
   
   I'm planning to use it in the REE array builder. Representing the current 
open run value with a `shared_ptr<Scalar>` and length.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to