felipecrv commented on code in PR #33941:
URL: https://github.com/apache/arrow/pull/33941#discussion_r1091969640
##########
cpp/src/arrow/type.h:
##########
@@ -2126,7 +2126,7 @@ Result<std::shared_ptr<Schema>> UnifySchemas(
namespace internal {
-static inline bool HasValidityBitmap(Type::type id) {
+inline constexpr bool HasValidityBitmap(Type::type id) {
Review Comment:
I don't really know and I was afraid not putting the `inline` in the header
could be an issue. Like, what happens if someone (in theory) takes a pointer to
this function? The compiler is forced to produce it in the binary. It won't be
able to inline it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
