js8544 commented on code in PR #33941:
URL: https://github.com/apache/arrow/pull/33941#discussion_r1092007982
##########
cpp/src/arrow/type.h:
##########
@@ -2126,7 +2126,7 @@ Result<std::shared_ptr<Schema>> UnifySchemas(
namespace internal {
-static inline bool HasValidityBitmap(Type::type id) {
+inline constexpr bool HasValidityBitmap(Type::type id) {
Review Comment:
I think the arrow codebase tends to omit inline keyword for constexpr
functions, for example in type_trait.h and [this
PR](https://github.com/apache/arrow/pull/14241).
P.S. I don't think the inline specifier has much to do with inline function
expansion for modern compilers. It's more for making sure ODR is not violated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
