pitrou commented on code in PR #33941:
URL: https://github.com/apache/arrow/pull/33941#discussion_r1092091108
##########
cpp/src/arrow/type.h:
##########
@@ -2126,7 +2126,7 @@ Result<std::shared_ptr<Schema>> UnifySchemas(
namespace internal {
-static inline bool HasValidityBitmap(Type::type id) {
+inline constexpr bool HasValidityBitmap(Type::type id) {
Review Comment:
Yes, according to the C++ reference, "A constexpr specifier used in a
function declaration implies inline".
https://en.cppreference.com/w/cpp/language/constexpr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
