pitrou commented on code in PR #33951:
URL: https://github.com/apache/arrow/pull/33951#discussion_r1092105287
##########
go/arrow/cdata/cdata_exports.go:
##########
@@ -385,7 +388,13 @@ func exportArray(arr arrow.Array, out *CArrowArray,
outSchema *CArrowSchema) {
for i := range bufs {
buf := bufs[i]
if buf == nil || buf.Len() == 0 {
- buffers[i] = nil
+ if i > 0 {
Review Comment:
This implies that buffer 0 is the null bitmap, which might not be true for
all types (such as unions).
By the way, the hardcoded check for unions above could instead use of more
generic API (such as `HasValidityBitmap` in Arrow C++).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
