zeroshade commented on code in PR #14223:
URL: https://github.com/apache/arrow/pull/14223#discussion_r1092212143
##########
go/arrow/ipc/metadata.go:
##########
@@ -425,6 +425,19 @@ func (fv *fieldVisitor) visit(field arrow.Field) {
flatbuf.MapAddKeysSorted(fv.b, dt.KeysSorted)
fv.offset = flatbuf.MapEnd(fv.b)
+ case *arrow.RunEndEncodedType:
+ fv.dtype = flatbuf.TypeRunEndEncoded
+ var offsets [2]flatbuffers.UOffsetT
+ offsets[0] = fieldToFB(fv.b, fv.pos.Child(0),
+ arrow.Field{Name: "run_ends", Type: dt.RunEnds()},
fv.memo)
Review Comment:
yes. Go will zero out everything by default and the zero-value for booleans
is false.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
