ianmcook commented on issue #33956: URL: https://github.com/apache/arrow/issues/33956#issuecomment-1410808592
>> The extension references and anchors are silly > > That was partly by design to emphasize that these can be any arbitrary integers. I find it makes it much more obvious how they are related. For example, if we used `0` instead of `7` then it would not be obvious that `extension_uri_reference` is a reference to `extension_uri_anchor`. Ah, got it, fair enough. >> #include <arrow/engine/api.h> needs to be changed to #include <arrow/engine/substrait/api.h> > >That seems a little surprising to me. What error did you get using `<arrow/engine/api.h>`? That file does not exist when I build and install the Arrow library (using a recent dev commit) : ``` % find /usr/local/include/arrow/engine /usr/local/include/arrow/engine /usr/local/include/arrow/engine/substrait /usr/local/include/arrow/engine/substrait/relation.h /usr/local/include/arrow/engine/substrait/pch.h /usr/local/include/arrow/engine/substrait/extension_types.h /usr/local/include/arrow/engine/substrait/type_fwd.h /usr/local/include/arrow/engine/substrait/options.h /usr/local/include/arrow/engine/substrait/extension_set.h /usr/local/include/arrow/engine/substrait/api.h /usr/local/include/arrow/engine/substrait/test_plan_builder.h /usr/local/include/arrow/engine/substrait/util.h /usr/local/include/arrow/engine/substrait/visibility.h /usr/local/include/arrow/engine/substrait/serde.h ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
