avantgardnerio commented on code in PR #33961:
URL: https://github.com/apache/arrow/pull/33961#discussion_r1092481407
##########
java/flight/flight-sql-jdbc-driver/src/main/java/org/apache/arrow/driver/jdbc/utils/ConvertUtils.java:
##########
@@ -37,6 +45,114 @@ public final class ConvertUtils {
private ConvertUtils() {
}
+ static boolean isSigned(ArrowType.ArrowTypeID type) {
+ switch (type) {
+ case Int:
+ case FloatingPoint:
+ case Decimal:
+ case Interval:
+ case Duration:
+ return true;
+ }
+ return false;
+ }
+
+ static int toJdbcType(ArrowType.ArrowTypeID type) {
Review Comment:
I am uncertain where these methods should go.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
