kou commented on code in PR #33808:
URL: https://github.com/apache/arrow/pull/33808#discussion_r1092682530
##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -455,6 +455,93 @@ else()
)
endif()
+if(DEFINED ENV{ARROW_AWS_C_AUTH_URL})
+ set(AWS_C_AUTH_SOURCE_URL "$ENV{ARROW_AWS_C_AUTH_URL}")
+else()
+ set_urls(AWS_C_AUTH_SOURCE_URL
+
"https://github.com/awslabs/aws-c-auth/archive/${ARROW_AWS_C_AUTH_BUILD_VERSION}.tar.gz";
+ )
+endif()
+
+if(DEFINED ENV{ARROW_AWS_C_CAL_URL})
+ set(AWS_C_CAL_SOURCE_URL "$ENV{ARROW_AWS_C_CAL_URL}")
+else()
+ set_urls(AWS_C_CAL_SOURCE_URL
+
"https://github.com/awslabs/aws-c-cal/archive/${ARROW_AWS_C_CAL_BUILD_VERSION}.tar.gz";
+ )
+endif()
+
+if(DEFINED ENV{ARROW_AWS_C_COMPRESSION_URL})
+ set(AWS_C_COMPRESSION_SOURCE_URL "$ENV{ARROW_AWS_C_COMPRESSION_URL}")
+else()
+ set_urls(AWS_C_COMPRESSION_SOURCE_URL
+
"https://github.com/awslabs/aws-c-compression/archive/${ARROW_AWS_C_COMPRESSION_BUILD_VERSION}.tar.gz";
+ )
+endif()
+
+if(DEFINED ENV{ARROW_AWS_C_HTTP_URL})
+ set(AWS_C_HTTP_SOURCE_URL "$ENV{ARROW_AWS_C_HTTP_URL}")
+else()
+ set_urls(AWS_C_HTTP_SOURCE_URL
+
"https://github.com/awslabs/aws-c-http/archive/${ARROW_AWS_C_HTTP_BUILD_VERSION}.tar.gz";
+ )
+endif()
+
+if(DEFINED ENV{ARROW_AWS_C_IO_URL})
+ set(AWS_C_IO_SOURCE_URL "$ENV{ARROW_AWS_C_IO_URL}")
+else()
+ set_urls(AWS_C_IO_SOURCE_URL
+
"https://github.com/awslabs/aws-c-io/archive/${ARROW_AWS_C_IO_BUILD_VERSION}.tar.gz";
+ )
+endif()
+
+if(DEFINED ENV{ARROW_AWS_C_MQTT_URL})
+ set(AWS_C_MQTT_SOURCE_URL "$ENV{ARROW_AWS_C_MQTT_URL}")
+else()
+ set_urls(AWS_C_MQTT_SOURCE_URL
+
"https://github.com/awslabs/aws-c-mqtt/archive/${ARROW_AWS_C_MQTT_BUILD_VERSION}.tar.gz";
+ )
+endif()
+
+if(DEFINED ENV{ARROW_AWS_C_S3_URL})
+ set(AWS_C_S3_SOURCE_URL "$ENV{ARROW_AWS_C_S3_URL}")
+else()
+ set_urls(AWS_C_S3_SOURCE_URL
+
"https://github.com/awslabs/aws-c-s3/archive/${ARROW_AWS_C_S3_BUILD_VERSION}.tar.gz";
+ )
+endif()
+
+if(DEFINED ENV{ARROW_AWS_C_SDKUTILS_URL})
+ set(AWS_C_SDKUTILS_SOURCE_URL "$ENV{ARROW_AWS_C_SDKUTILS_URL}")
+else()
+ set_urls(AWS_C_SDKUTILS_SOURCE_URL
+
"https://github.com/awslabs/aws-c-sdkutils/archive/${ARROW_AWS_C_SDKUTILS_BUILD_VERSION}.tar.gz";
+ )
+endif()
+
+if(DEFINED ENV{ARROW_AWS_LC_URL})
+ set(AWS_LC_SOURCE_URL "$ENV{ARROW_AWS_LC_URL}")
+else()
+ set_urls(AWS_LC_SOURCE_URL
+
"https://github.com/awslabs/aws-lc/archive/${ARROW_AWS_LC_BUILD_VERSION}.tar.gz";
+ )
+endif()
+
+if(DEFINED ENV{ARROW_S2N_URL})
+ set(S2N_SOURCE_URL "$ENV{ARROW_S2N_URL}")
+else()
+ set_urls(S2N_SOURCE_URL
+
"https://github.com/awslabs/s2n/archive/${ARROW_S2N_BUILD_VERSION}.tar.gz";)
+endif()
Review Comment:
`awslabs` -> `aws`: https://github.com/aws/s2n-tls/archive/v1.3.27.tar.gz
Could you use `S2N_TLS` instead of `S2N` like `ARROW_S2N_TLS_URL` for all
s2n-tls related variables?
BTW, the latest release is 1.3.35: https://github.com/aws/s2n-tls/releases
Can we use the latest version?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
