alamb commented on PR #5115: URL: https://github.com/apache/arrow-datafusion/pull/5115#issuecomment-1412108553
> I guess it would be nice to understand if Datafusion wants to have type checks in sqllogictest at all. > Otherwise, query <LETTER> don't mean much for now. For example, the letter T is supposed to be "text" in sqllogictest. I think adding this verification is tracked in https://github.com/apache/arrow-datafusion/issues/4499 - it seems like a valuable addition to me, but I haven't gotten around to implement it yet. I agree having a bunch of letters that look like they are checked but are silently ignored is probably worse than not having them at all > It is probably easier to go DuckDBs way and check only the number of columns. And rely on arrow_type for type checks. That would be fine with me too -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
