brettbuddin commented on PR #33983: URL: https://github.com/apache/arrow/pull/33983#issuecomment-1412943819
@zeroshade I took a crack at it. I realized that the server shutdown is never closing the SQLite database so even though we're creating a new server structure and overwriting `srv` in the tests, it will continue to think its in the same memory space. We'd have the same problem if we simply pushed it down into the tests without closure. I'm not exactly happy with the shape of what I have though. It seems like the owning Flight server should be able to ensure this is called without me manually calling it the teardown. function. However, there isn't a suitable hook point without being too invasive in `server.go` and friends. The `Shutdown()` I've added feels tacked on, because it is. Either `db.Close()` will need to be called or a new "memory space" will need to be created explicitly for each server start-up via something like `file:<random-id-for-server>?mode=memory&cache=shared` in dialing. My vote is for proper closure, because it's less articulation. However, if concurrent execution of test cases (like you mentioned) is a priority, the new memory space idea should be considered. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
