kou commented on issue #33920: URL: https://github.com/apache/arrow/issues/33920#issuecomment-1413224279
> libprotobuf on Ubuntu only provides static libraries Not correct (both of static libraries and shared libraries are provided): * `liprotobuf23`: https://packages.ubuntu.com/jammy/amd64/libprotobuf23/filelist includes `libprotobuf.so.23*` * `libprotobuf-dev`: https://packages.ubuntu.com/jammy/amd64/libprotobuf-dev/filelist includes `libprotobuf.{a,so}` > doesn't contain any cmake files Correct. > I think this means we would also need to create a `FindProtobuf.cmake` that checks if `ARROW_PROTOBUF_USE_SHARED` and, if so, then looks for the `.a` We already have `FindProtobufAlt.cmake` and it did that. :-) The following patch will disable Flight SQL only in ASAN job: ```diff diff --git a/.github/workflows/cpp.yml b/.github/workflows/cpp.yml index 4959197fcd..523e6fec5d 100644 --- a/.github/workflows/cpp.yml +++ b/.github/workflows/cpp.yml @@ -66,8 +66,11 @@ jobs: - ubuntu-cpp-sanitizer include: - image: conda-cpp + docker-run-options: title: AMD64 Conda C++ - image: ubuntu-cpp-sanitizer + docker-run-options: >- + -e ARROW_FLIGHT_SQL=OFF title: AMD64 Ubuntu 22.04 C++ ASAN UBSAN env: UBUNTU: "22.04" @@ -96,7 +99,7 @@ jobs: run: | sudo sysctl -w kernel.core_pattern="core.%e.%p" ulimit -c unlimited - archery docker run ${{ matrix.image }} + archery docker run ${{ matrix.docker-run-options }} ${{ matrix.image }} - name: Docker Push if: success() && github.event_name == 'push' && github.repository == 'apache/arrow' env: ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
