waitingkuo commented on code in PR #5140:
URL: https://github.com/apache/arrow-datafusion/pull/5140#discussion_r1094229758
##########
datafusion/expr/src/type_coercion/binary.rs:
##########
@@ -541,33 +541,30 @@ fn is_time_with_valid_unit(datatype: DataType) -> bool {
fn temporal_coercion(lhs_type: &DataType, rhs_type: &DataType) ->
Option<DataType> {
use arrow::datatypes::DataType::*;
match (lhs_type, rhs_type) {
- (Date64, Date32) => Some(Date64),
- (Date32, Date64) => Some(Date64),
- (Utf8, Date32) => Some(Date32),
- (Date32, Utf8) => Some(Date32),
- (Utf8, Date64) => Some(Date64),
- (Date64, Utf8) => Some(Date64),
- (Utf8, Time32(unit)) => match
is_time_with_valid_unit(Time32(unit.clone())) {
- false => None,
- true => Some(Time32(unit.clone())),
- },
- (Time32(unit), Utf8) => match
is_time_with_valid_unit(Time32(unit.clone())) {
- false => None,
- true => Some(Time32(unit.clone())),
- },
- (Utf8, Time64(unit)) => match
is_time_with_valid_unit(Time64(unit.clone())) {
- false => None,
- true => Some(Time64(unit.clone())),
- },
- (Time64(unit), Utf8) => match
is_time_with_valid_unit(Time64(unit.clone())) {
- false => None,
- true => Some(Time64(unit.clone())),
- },
- (Timestamp(_, tz), Utf8) => Some(Timestamp(TimeUnit::Nanosecond,
tz.clone())),
- (Utf8, Timestamp(_, tz)) => Some(Timestamp(TimeUnit::Nanosecond,
tz.clone())),
- // TODO: need to investigate the result type for the comparison
between timestamp and date
- (Timestamp(_, _), Date32) => Some(Date32),
- (Timestamp(_, _), Date64) => Some(Date64),
+ (Date64, Date32) | (Date32, Date64) => Some(Date64),
+ (Utf8, Date32) | (Date32, Utf8) => Some(Date32),
+ (Utf8, Date64) | (Date64, Utf8) => Some(Date64),
+ (Utf8, Time32(unit)) | (Time32(unit), Utf8) => {
+ match is_time_with_valid_unit(Time32(unit.clone())) {
+ false => None,
+ true => Some(Time32(unit.clone())),
+ }
+ }
+ (Utf8, Time64(unit)) | (Time64(unit), Utf8) => {
+ match is_time_with_valid_unit(Time64(unit.clone())) {
+ false => None,
+ true => Some(Time64(unit.clone())),
+ }
+ }
+ (Timestamp(_, tz), Utf8) | (Utf8, Timestamp(_, tz)) => {
+ Some(Timestamp(TimeUnit::Nanosecond, tz.clone()))
+ }
+ (Timestamp(_, None), Date32) | (Date32, Timestamp(_, None)) => {
+ Some(Timestamp(TimeUnit::Nanosecond, None))
+ }
+ (Timestamp(_, _tz), Date32) | (Date32, Timestamp(_, _tz)) => {
+ Some(Timestamp(TimeUnit::Nanosecond, None))
+ }
Review Comment:
does it mean that we convert Timestamptz to Timestamp and then compare?
##########
datafusion/expr/src/type_coercion/binary.rs:
##########
@@ -541,33 +541,30 @@ fn is_time_with_valid_unit(datatype: DataType) -> bool {
fn temporal_coercion(lhs_type: &DataType, rhs_type: &DataType) ->
Option<DataType> {
use arrow::datatypes::DataType::*;
match (lhs_type, rhs_type) {
- (Date64, Date32) => Some(Date64),
- (Date32, Date64) => Some(Date64),
- (Utf8, Date32) => Some(Date32),
- (Date32, Utf8) => Some(Date32),
- (Utf8, Date64) => Some(Date64),
- (Date64, Utf8) => Some(Date64),
- (Utf8, Time32(unit)) => match
is_time_with_valid_unit(Time32(unit.clone())) {
- false => None,
- true => Some(Time32(unit.clone())),
- },
- (Time32(unit), Utf8) => match
is_time_with_valid_unit(Time32(unit.clone())) {
- false => None,
- true => Some(Time32(unit.clone())),
- },
- (Utf8, Time64(unit)) => match
is_time_with_valid_unit(Time64(unit.clone())) {
- false => None,
- true => Some(Time64(unit.clone())),
- },
- (Time64(unit), Utf8) => match
is_time_with_valid_unit(Time64(unit.clone())) {
- false => None,
- true => Some(Time64(unit.clone())),
- },
- (Timestamp(_, tz), Utf8) => Some(Timestamp(TimeUnit::Nanosecond,
tz.clone())),
- (Utf8, Timestamp(_, tz)) => Some(Timestamp(TimeUnit::Nanosecond,
tz.clone())),
- // TODO: need to investigate the result type for the comparison
between timestamp and date
- (Timestamp(_, _), Date32) => Some(Date32),
- (Timestamp(_, _), Date64) => Some(Date64),
+ (Date64, Date32) | (Date32, Date64) => Some(Date64),
+ (Utf8, Date32) | (Date32, Utf8) => Some(Date32),
+ (Utf8, Date64) | (Date64, Utf8) => Some(Date64),
+ (Utf8, Time32(unit)) | (Time32(unit), Utf8) => {
+ match is_time_with_valid_unit(Time32(unit.clone())) {
+ false => None,
+ true => Some(Time32(unit.clone())),
+ }
+ }
+ (Utf8, Time64(unit)) | (Time64(unit), Utf8) => {
+ match is_time_with_valid_unit(Time64(unit.clone())) {
+ false => None,
+ true => Some(Time64(unit.clone())),
+ }
+ }
+ (Timestamp(_, tz), Utf8) | (Utf8, Timestamp(_, tz)) => {
+ Some(Timestamp(TimeUnit::Nanosecond, tz.clone()))
+ }
Review Comment:
i tried this, but it didn't work
```bash
❯ select '2000-01-01T00:00:00'::timestamp::timestamptz =
'2000-01-01T00:00:00';
Internal("The type of Timestamp(Nanosecond, Some(\"+00:00\")) Eq Utf8 of
binary physical should be same")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
