westonpace commented on PR #15180: URL: https://github.com/apache/arrow/pull/15180#issuecomment-1413866907
The test failures revealed another issue which I addressed here. In `DispatchBest` for simple arithmetic we were declaring `float32` to be the common type between `decimal` and `float32`. However, I believe `float64` is a more accurate choice. This also matches the [rule we use for trigonometric functions](https://github.com/apache/arrow/blob/apache-arrow-11.0.0/cpp/src/arrow/compute/kernels/scalar_arithmetic.cc#L749-L753). CC @lidavidm for second opinion. @nealrichardson there was another R test failure which I deemed inevitable and I have updated the test. It is a slight behavior change. Does this seem acceptable: https://github.com/apache/arrow/pull/15180/files#diff-45391fbe156c77f99e14090369faed8e11ec49583634fa1a51b634ef8b9eb5bf -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
