rtpsw commented on PR #33909: URL: https://github.com/apache/arrow/pull/33909#issuecomment-1413945487
> Looking at this further I do worry that `kind` will be too restrictive. For example, if you are writing to a temporary output directory and the `name` specifies the path then how do you configure the directory to write to? Something like `kind = "write_to_temp"` and `name = "/path/to/tmp.XXXXXX"`. The `XXXXXX` part has the same meaning [as in `mktemp(1)`](https://linux.die.net/man/1/mktemp). > Perhaps that might be what you intended with the nesting of node factories? E.g. you would register a node factory that had the output directory hard-coded as a part of the node factory? One could register some node factory to implement a very specific custom behavior, and it's good that this option is available to users, but the above example is simple enough that it won't be needed for it. If we settle on this `kind`+`name` structure, we'd want to encourage its application, i.e., the recommendation would be to use `kind` to specify the functionality and `name` to specify its configuration whenever possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
