cboettig commented on PR #33918: URL: https://github.com/apache/arrow/pull/33918#issuecomment-1414111299
I do like `s3_bucket()` as part of the R API, and think we should keep it. It's a concise wrapper around a common pattern of: 1. guess region (optional) 2. create s3 filesystem 3. create subtree filesystem When introducing new users to the S3 Filesystem, learning one new function with a nice obvious name that starts with `s3_` is far less intimidating than the three considerably more verbose methods using the less familiar `$create()` constructor (I say this after having tried showing `s3_bucket()` to basically anyone who has ever used R and will listen to me over the past year :joy: ). Most other APIs offer similar patterns, as does arrow with the `gs_bucket()` analogue. I totally get the desire for a quick fix. I think the natural thing to do right now is: https://github.com/apache/arrow/pull/34009/files, i.e. since `from_uri` is ignoring all optional args already and thus only gives the intended behavior when optional args are not provided (as in the unit test), then we should only hit it when no optional arguments have been included. I *think* that should pass the current tests and preserve the existing behavior in all cases where the existing behavior was desirable (e.g. guessing bucket region when no region is given when using the default endpoint), while only altering things where the existing behavior was flawed (e.g. currently a user of even the default endpoint who manually requests a region different from what the bucket header says will find their requested region ignored). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
