rtpsw commented on code in PR #33909:
URL: https://github.com/apache/arrow/pull/33909#discussion_r1095088266
##########
cpp/src/arrow/engine/substrait/options.h:
##########
@@ -67,6 +68,10 @@ using NamedTableProvider =
std::function<Result<compute::Declaration>(const
std::vector<std::string>&)>;
static NamedTableProvider kDefaultNamedTableProvider;
+using NamedTapKindMapper = std::function<Result<std::string>(const
std::string&)>;
+static NamedTapKindMapper kDefaultNamedTapKindMapper =
Review Comment:
A string-typed argument is not sufficient for creating a declaration for an
internal (non-source) node - the input declarations are required, and probably
options too. Another reason for the differing signatures is that here the
string-typed parameter is for the tap kind, which is semantically different
than a table name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
