ygf11 commented on issue #5157: URL: https://github.com/apache/arrow-datafusion/issues/5157#issuecomment-1414654588
> And a large part of that is how it ignores errors with .ok() where were quite expensive to produce The result type of `field_with_name` is `Result<&DFField>`, it is not clear enough I think. For the method `field_with_name`, there are three result for the given name: 1. There is no such field, return FieldNotFound error. 2. Find only one field, return this field. 3. Find one more field, return Ambiguous reference error. The first and third both will return error, in most times we should distingwish them, but it is not easy. Maybe we can change to `Result<Option<&Field>>`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
