jorisvandenbossche commented on PR #33974: URL: https://github.com/apache/arrow/pull/33974#issuecomment-1416097157
@Fokko thanks for the catch! You are currently updating the docstring of ParquetDataset, but we should do the same update for read_table: https://github.com/apache/arrow/blob/78a8da42d1fc364e84286afc88a25fa5b819d092/python/pyarrow/parquet/core.py#L2775 (I think it's also `read_table` you are using in PyIceberg, and not `ParquetDataset`?) > > Do you want me to create a PR to copy those docs? Because of the redirect, the arguments are also not showing up in PyCharm. Let me know and I'll create a PR. > > Yes, I think that is a good idea but I might CC @jorisvandenbossche or @amol- to weigh in on whether they know some better way to avoid the duplication or have a preference here (I normally focus on the C++ end of things.) Yeah, I think we should prefer some duplication if that gives better docstrings. I agree the indirection for the user right now isn't very user friendly. We might be able to share some part of the docstring and inject that in multiple places to avoid duplicating the actual content, if that doesn't make things too complicated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
