maartenbreddels commented on a change in pull request #8628:
URL: https://github.com/apache/arrow/pull/8628#discussion_r522326005
##########
File path: cpp/src/arrow/compute/kernels/codegen_internal.h
##########
@@ -1058,6 +1058,22 @@ ArrayKernelExec
GenerateTypeAgnosticPrimitive(detail::GetTypeId get_id) {
}
}
+/// similar to GenerateTypeAgnosticPrimitive, but for variable types
+template <template <typename...> class Generator>
+ArrayKernelExec GenerateTypeAgnosticVarBinaryBase(detail::GetTypeId get_id) {
+ switch (get_id.id) {
+ case Type::BINARY:
+ case Type::STRING:
+ return Generator<BinaryType>::Exec;
Review comment:
Yeah, following the convention I was being used in the fill_na for
primitives/temporals.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
