westonpace commented on issue #34035: URL: https://github.com/apache/arrow/issues/34035#issuecomment-1416244604
> Looking at cpp/src/arrow/compute/exec/swiss_join.h, I see cpp/src/arrow/compute/exec/swiss_join.cc includes it at the top. IIUC, changing the include to cpp/src/arrow/compute/exec/swiss_join_internal.h would require it be moved to its sorted order in the includes? Yes. Basically everything that is not in `arrow/compute/api.h` should be marked internal. So there are quite a few headers that will need to change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
