westonpace commented on code in PR #34036:
URL: https://github.com/apache/arrow/pull/34036#discussion_r1096268449
##########
cpp/src/arrow/compute/exec/util.h:
##########
@@ -57,6 +56,15 @@
#endif
namespace arrow {
+
+namespace internal {
+namespace tracing {
+
+struct Scope;
+
+} // namespace tracing
+} // namespace internal
+
Review Comment:
Can we instead add `Scope` to `arrow/util/type_fwd.h` (and include that here)
##########
cpp/src/arrow/compute/exec/util.h:
##########
@@ -234,6 +242,8 @@ class bit_util {
} // namespace util
namespace compute {
+class ExecNode;
Review Comment:
Instead can we include `arrow/compute/type_fwd.h`?
##########
cpp/src/arrow/compute/exec/util.h:
##########
@@ -36,7 +36,6 @@
#include "arrow/util/logging.h"
#include "arrow/util/mutex.h"
#include "arrow/util/thread_pool.h"
-#include "arrow/util/tracing_internal.h"
Review Comment:
Note, this header is still an internal header as it includes
`arrow/util/logging.h` which is perhaps our most egregious improperly named
header.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
