nealrichardson commented on PR #15180: URL: https://github.com/apache/arrow/pull/15180#issuecomment-1416783363
I pulled this, removed the R code that tries to make scalar inputs match the type of the corresponding fields where safe and appropriate, and ran the tests. I was surprised to see that `field<int32> * 1<float64>` resulted in `float32`. The R code I would be removing checks that `1<float64>` can be represented as `int32` (the field's type) without loss, and if so, it casts it to match the field. It's fine with me if the acero code doesn't want to use that rule, but I found the result of `float32`, i.e. casting both inputs to something else, surprising. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
