felipecrv commented on code in PR #14223:
URL: https://github.com/apache/arrow/pull/14223#discussion_r1097697486
##########
go/arrow/encoded/ree_utils.go:
##########
@@ -23,38 +23,55 @@ import (
"github.com/apache/arrow/go/v12/arrow"
)
-// FindPhysicalOffset performs a binary search on the run-ends to return
+// FindPhysicalIndex performs a binary search on the run-ends to return
Review Comment:
Oh, I should do this rename on the C++ impl as well, right? From
`FindPhysicalOffset(offset)` to `PhysicalIndex(index)` and have
`FindPhysicalOffset()` defined in terms of `FindPhysicalIndex(offset)`?
##########
go/arrow/encoded/ree_utils.go:
##########
@@ -23,38 +23,55 @@ import (
"github.com/apache/arrow/go/v12/arrow"
)
-// FindPhysicalOffset performs a binary search on the run-ends to return
+// FindPhysicalIndex performs a binary search on the run-ends to return
Review Comment:
Oh, I should do this rename on the C++ impl as well, right? From
`FindPhysicalOffset(offset)` to `PhysicalIndex(index)` and have
`FindPhysicalOffset()` defined in terms of `FindPhysicalIndex(offset)`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
