vibhatha commented on code in PR #33969:
URL: https://github.com/apache/arrow/pull/33969#discussion_r1098079831
##########
cpp/src/arrow/dataset/partition.cc:
##########
@@ -827,7 +827,7 @@ class HivePartitioningFactory : public
KeyValuePartitioningFactory {
Result<std::shared_ptr<Partitioning>> Finish(
const std::shared_ptr<Schema>& schema) const override {
if (dictionaries_.empty()) {
- return std::make_shared<HivePartitioning>(schema, dictionaries_);
+ return std::make_shared<HivePartitioning>(arrow::schema({}),
dictionaries_);
Review Comment:
There is an arugment `schema` to the function, so it would need either
refactoring argument or using the namespace. Any thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
