mapleFU commented on code in PR #33995:
URL: https://github.com/apache/arrow/pull/33995#discussion_r1098505376
##########
cpp/src/parquet/bloom_filter.h:
##########
@@ -36,7 +36,7 @@ class PARQUET_EXPORT BloomFilter {
public:
// Maximum Bloom filter size, it sets to HDFS default block size 128MB
// This value will be reconsidered when implementing Bloom filter producer.
- static constexpr uint32_t kMaximumBloomFilterBytes = 128 * 1024 * 1024;
+ static constexpr uint64_t kMaximumBloomFilterBytes = 128 * 1024 * 1024;
Review Comment:
Currently just keep it uint32_t is ok, since it could support 4G. For
`Bits`, its 1G Bytes, and it's 8 times greater than `kMaximumBloomFilterBytes`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
