lidavidm commented on code in PR #428: URL: https://github.com/apache/arrow-adbc/pull/428#discussion_r1100169833
########## adbc.h: ########## @@ -1183,7 +1204,11 @@ AdbcStatusCode AdbcStatementExecutePartitions(struct AdbcStatement* statement, /// driver. /// /// Although drivers may choose any name for this function, the -/// recommended name is "AdbcDriverInit". +/// recommended name is "AdbcDriverInit". If you use the recommended +/// name, then driver managers will be able to automatically find +/// the entrypoint function. Drivers may also expose the same function +/// under a unique symbol so that multiple drivers can be statically +/// linked into a single binary without any conflicts. Review Comment: This dance mostly comes from also allowing you to directly link to and use a driver. If we dropped that and specified that you must always/only use the driver manager, we could avoid this (there would still be AdbcDriverInit, but we could say something like the user must always provide the name of the symbol, or the name of the symbol is derived from the name of the library, or something like that). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
