tustvold commented on code in PR #3647:
URL: https://github.com/apache/arrow-rs/pull/3647#discussion_r1100212470
##########
parquet/src/arrow/arrow_writer/mod.rs:
##########
@@ -2314,17 +2314,17 @@ mod tests {
// Verify data is as expected
let expected = r#"
-
+-------------------------------------------------------------------------------------------------------------------------------------+
- | struct_b
|
-
+-------------------------------------------------------------------------------------------------------------------------------------+
- | {"list": [{"leaf_a": 1, "leaf_b": 1}]}
|
- | {"list": null}
|
- | {"list": [{"leaf_a": 2, "leaf_b": null}, {"leaf_a": 3, "leaf_b":
2}]} |
- | {"list": null}
|
- | {"list": [{"leaf_a": 4, "leaf_b": null}, {"leaf_a": 5, "leaf_b":
null}]} |
- | {"list": [{"leaf_a": 6, "leaf_b": null}, {"leaf_a": 7, "leaf_b":
null}, {"leaf_a": 8, "leaf_b": null}, {"leaf_a": 9, "leaf_b": 1}]} |
- | {"list": [{"leaf_a": 10, "leaf_b": null}]}
|
-
+-------------------------------------------------------------------------------------------------------------------------------------+
+
+-------------------------------------------------------------------------------------------------------+
Review Comment:
Yes, if someone wants actual JSON, they should use the JSON writer, what
this previously produced was quasi-JSON that wouldn't illegal escape characters
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
