assignUser commented on PR #34032: URL: https://github.com/apache/arrow/pull/34032#issuecomment-1423081463
Thanks for the PR, sounds useful . I personally am not a fan of vendoring entire repos if there is no need for it. In this case you seem to know a specific rev that works, so I would prefer to get the repo via FetchContent (as we are bumping cmake to 3.16 for 12.0.0)/EP and use the provided cmake code & config to integrate it into the build process. But I am no cpp maintainer so I will defer to other opinions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
