viirya commented on code in PR #3678: URL: https://github.com/apache/arrow-rs/pull/3678#discussion_r1100614718
########## arrow-array/src/array/primitive_array.rs: ########## @@ -168,22 +168,42 @@ pub type TimestampNanosecondArray = PrimitiveArray<TimestampNanosecondType>; // TODO: give examples for the below types -/// A primitive array where each element is of 32-bit date type. +/// A primitive array where each element is of 32-bit value +/// representing the elapsed time since UNIX epoch in days." +/// +/// This type is similar to the [`chrono::NaiveDate`] type and can hold +/// values such as `2018-11-13` pub type Date32Array = PrimitiveArray<Date32Type>; -/// A primitive array where each element is of 64-bit date type. +/// A primitive array where each element is a 64-bit value +/// representing the elapsed time since the UNIX epoch in milliseconds. +/// +/// This type is similar to the [`chrono::DateTime`] type and can hold +/// values such as `2018-11-13T17:11:10.011` pub type Date64Array = PrimitiveArray<Date64Type>; /// An array where each element is of 32-bit type representing time elapsed in seconds /// since midnight. +/// +/// This type is similar to the [`chrono::NaiveTime`] type and can +/// hold values such as `00:02:00` pub type Time32SecondArray = PrimitiveArray<Time32SecondType>; /// An array where each element is of 32-bit type representing time elapsed in milliseconds /// since midnight. +/// +/// This type is similar to the [`chrono::NaiveTime`] type and can +/// hold values such as `00:02:00.123` pub type Time32MillisecondArray = PrimitiveArray<Time32MillisecondType>; /// An array where each element is of 64-bit type representing time elapsed in microseconds /// since midnight. +/// +/// This type is similar to the [`chrono::NaiveTime`] type and can +/// hold values such as `00:02:00.000123` pub type Time64MicrosecondArray = PrimitiveArray<Time64MicrosecondType>; /// An array where each element is of 64-bit type representing time elapsed in nanoseconds /// since midnight. +/// +/// This type is similar to the [`chrono::NaiveTime`] type and can +/// hold values such as `00:02:00.000000123` Review Comment: easier to read. 😄 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
