felipecrv commented on code in PR #34079:
URL: https://github.com/apache/arrow/pull/34079#discussion_r1100785369
##########
go/arrow/scalar/nested.go:
##########
@@ -744,3 +745,72 @@ func (s *DenseUnion) ChildValue() Scalar { return s.Value }
func NewDenseUnionScalar(v Scalar, code arrow.UnionTypeCode, dt
*arrow.DenseUnionType) *DenseUnion {
return &DenseUnion{scalar: scalar{dt, v.IsValid()}, TypeCode: code,
Value: v}
}
+
+type RunEndEncoded struct {
+ scalar
+
+ RunLength int64
Review Comment:
Nitpick: I called it `run_end` in C++ and it fit more naturally with the
rest of the code.
For example:
- it's typed by the "run end" type
- the value 0 is invalid (no run ends array should contain 0) representing
the null scalar
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
