askoa commented on code in PR #3662:
URL: https://github.com/apache/arrow-rs/pull/3662#discussion_r1101542312
##########
arrow-ipc/src/writer.rs:
##########
@@ -1242,24 +1289,45 @@ fn write_array_data(
}
}
- if !matches!(array_data.data_type(), DataType::Dictionary(_, _)) {
- // recursively write out nested structures
- for data_ref in array_data.child_data() {
- // write the nested data (e.g list data)
- offset = write_array_data(
- data_ref,
- buffers,
- arrow_data,
- nodes,
- offset,
- data_ref.len(),
- data_ref.null_count(),
- compression_codec,
- write_options,
- )?;
+ match array_data.data_type() {
+ DataType::Dictionary(_, _) => {}
+ DataType::RunEndEncoded(_, _) => {
+ // unslice the run encoded array.
+ let arr = unslice_run_array(array_data.clone())?;
Review Comment:
In case of non-zero offset, a new `RunArray` is created in
`into_non_sliced_array` whose default `offset` value is zero.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
