zeroshade commented on code in PR #34079:
URL: https://github.com/apache/arrow/pull/34079#discussion_r1101673297
##########
go/arrow/scalar/nested.go:
##########
@@ -744,3 +745,72 @@ func (s *DenseUnion) ChildValue() Scalar { return s.Value }
func NewDenseUnionScalar(v Scalar, code arrow.UnionTypeCode, dt
*arrow.DenseUnionType) *DenseUnion {
return &DenseUnion{scalar: scalar{dt, v.IsValid()}, TypeCode: code,
Value: v}
}
+
+type RunEndEncoded struct {
+ scalar
+
+ RunLength int64
+ Value Scalar
+}
+
+func NewRunEndEncodedScalar(v Scalar, runLength int64, dt
*arrow.RunEndEncodedType) *RunEndEncoded {
+ return &RunEndEncoded{scalar: scalar{dt, true}, RunLength: runLength,
Value: v}
+}
+
+func (s *RunEndEncoded) Release() {
+ if r, ok := s.Value.(Releasable); ok {
+ r.Release()
+ }
+}
+
+func (s *RunEndEncoded) value() interface{} { return s.Value.value() }
+
+func (s *RunEndEncoded) Validate() (err error) {
+ if err = s.Value.Validate(); err != nil {
+ return
+ }
+
+ if err = validateOptional(&s.scalar, s.value(), "value"); err != nil {
+ return
+ }
+
+ if !s.Valid {
+ return
+ }
+
+ if s.Type.ID() != arrow.RUN_END_ENCODED {
+ err = fmt.Errorf("%w: run-end-encoded scalar should not have
type %s",
+ arrow.ErrInvalid, s.Type)
+ }
+ return
+}
+
+func (s *RunEndEncoded) ValidateFull() error { return s.Validate() }
+
+func (s *RunEndEncoded) equals(rhs Scalar) bool {
+ other := rhs.(*RunEndEncoded)
+ return s.RunLength == other.RunLength && Equals(s.Value, other.Value)
Review Comment:
`scalar.Equals` already handles that portion of the comparison as a common
implementation check `scalar/compare.go`. We only get to the `equals` method on
a type if both sides are `Valid`. Which if i update the above to make `Valid`
be `runLength > 0` means that case will be handled by the common implementation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
