tustvold opened a new issue, #3684:
URL: https://github.com/apache/arrow-rs/issues/3684

   **Describe the bug**
   <!--
   A clear and concise description of what the bug is.
   -->
   
   `ArrowArray::try_from_raw` accepts `*const FFI_ArrowArray` and `*const 
FFI_ArrowSchema`. As of https://github.com/apache/arrow-rs/pull/1449 no longer 
takes ownership of the pointers, and instead "moves" the contents into its own 
allocations. The method is unsafe, and so this technically isn't unsound, but 
it is fairly surprising to people unfamiliar with the interface who might 
assume they can pass in a const reference.
   
   Related to this, the fact it doesn't take ownership makes it very easy to 
accidentally leak memory https://github.com/apache/arrow-rs/pull/1878 and 
https://github.com/apache/arrow-rs/issues/3683
   
   **To Reproduce**
   <!--
   Steps to reproduce the behavior:
   -->
   
   **Expected behavior**
   <!--
   A clear and concise description of what you expected to happen.
   -->
   
   **Additional context**
   <!--
   Add any other context about the problem here.
   -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to