Tommo56700 commented on code in PR #33603:
URL: https://github.com/apache/arrow/pull/33603#discussion_r1101704200
##########
csharp/src/Apache.Arrow/Ipc/ArrowStreamReader.cs:
##########
@@ -31,26 +31,41 @@ public class ArrowStreamReader : IArrowReader, IDisposable
public Schema Schema => _implementation.Schema;
public ArrowStreamReader(Stream stream)
- : this(stream, allocator: null, leaveOpen: false)
+ : this(stream, allocator: null, compressionCodecFactory: null,
leaveOpen: false)
{
}
public ArrowStreamReader(Stream stream, MemoryAllocator allocator)
- : this(stream, allocator, leaveOpen: false)
+ : this(stream, allocator, compressionCodecFactory: null,
leaveOpen: false)
+ {
+ }
+
+ public ArrowStreamReader(Stream stream, ICompressionCodecFactory
compressionCodecFactory)
+ : this(stream, allocator: null, compressionCodecFactory,
leaveOpen: false)
{
}
public ArrowStreamReader(Stream stream, bool leaveOpen)
- : this(stream, allocator: null, leaveOpen)
+ : this(stream, allocator: null, compressionCodecFactory: null,
leaveOpen)
{
}
public ArrowStreamReader(Stream stream, MemoryAllocator allocator,
bool leaveOpen)
+ : this(stream, allocator, compressionCodecFactory: null, leaveOpen)
+ {
+ }
+
+ public ArrowStreamReader(Stream stream, ICompressionCodecFactory
compressionCodecFactory, bool leaveOpen)
+ : this(stream, allocator: null, compressionCodecFactory, leaveOpen)
+ {
+ }
+
+ public ArrowStreamReader(Stream stream, MemoryAllocator allocator,
ICompressionCodecFactory compressionCodecFactory, bool leaveOpen)
{
if (stream == null)
throw new ArgumentNullException(nameof(stream));
- _implementation = new ArrowStreamReaderImplementation(stream,
allocator, leaveOpen);
+ _implementation = new ArrowStreamReaderImplementation(stream,
allocator, compressionCodecFactory, leaveOpen);
}
public ArrowStreamReader(ReadOnlyMemory<byte> buffer)
Review Comment:
Why not add compression support for ArrowMemoryReaderImplementation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
