mustafasrepo opened a new pull request, #5228:
URL: https://github.com/apache/arrow-datafusion/pull/5228
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
Closes #.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
As suggested by @mingmwang in the
[discussion](https://github.com/apache/arrow-datafusion/pull/5171#discussion_r1099988290).
Comparing ordering between schemas when there are multiple executors in
between them may produce incorrect results. Although this situation may not
arise in practice with the current ordering of the optimization rules. We have
changed the implementation in case one encounters it (Nobody knows).
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
With this change parallelize sort rule compares the immediate table for
converting `Coalesce + Executors that do not require SingleDistribution + Sort`
cascades to `Executors that do not require SingleDistribution + Sort +
SortPreservingMerge` cascade.
We also added a check that the final Sort in the cascade rule is actually a
Global sort.
# Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are
they covered by existing tests)?
-->
We added a unit test to verify that rule only ends when Sort is a global
sort. Also, the existing
[test](https://github.com/synnada-ai/arrow-datafusion/blob/157e204bb35e5e1466b8d6c11846e1a15ef048e5/datafusion/core/src/physical_optimizer/sort_enforcement.rs#L1680)
checks the sort comparison is done between immediate executors.
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
