nevi-me commented on a change in pull request #8660:
URL: https://github.com/apache/arrow/pull/8660#discussion_r523368564



##########
File path: rust/datafusion/src/physical_plan/mod.rs
##########
@@ -100,6 +100,30 @@ pub enum Distribution {
     SinglePartition,
 }
 
+/// Represents the result from an expression
+pub enum ColumnarValue {

Review comment:
       C++ uses a `Datum`, which is also an enum over Scalar, Array, and a few 
other things.
   We could have a separate module called `arrow::scalar`, then in the long run 
we could convert the compute kernels to take `Datum`, and push the 
optimisations of "array vs scalar" there




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to