westonpace commented on code in PR #34060:
URL: https://github.com/apache/arrow/pull/34060#discussion_r1101953195
##########
cpp/src/arrow/compute/exec/exec_plan.h:
##########
@@ -408,6 +408,54 @@ struct ARROW_EXPORT Declaration {
std::string label;
};
+struct ARROW_EXPORT QueryOptions {
+ QueryOptions();
+
+ /// \brief Should the plan use a legacy batching strategy
+ ///
+ /// This is currently in place only to support the Scanner::ToTable
+ /// method. This method relies on batch indices from the scanner
+ /// remaining consistent. This is impractical in the ExecPlan which
+ /// might slice batches as needed (e.g. for a join)
+ ///
+ /// However, it still works for simple plans and this is the only way
+ /// we have at the moment for maintaining implicit order.
+ bool use_legacy_batching;
Review Comment:
Done (also got rid of the explicit constructor)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
