mapleFU commented on PR #34114: URL: https://github.com/apache/arrow/pull/34114#issuecomment-1425439934
@kou Hi kou, sorry for disturbing you. I find a naive problem: Currently we download from "github.com/facebook/zstd/archive/", and it hash tags differ from hashtag in release note. Currently we use "https://github.com/facebook/zstd/archive/${ARROW_ZSTD_BUILD_VERSION}.tar.gz";, and can have `ARROW_ZSTD_BUILD_VERSION` like `v1.5.2` or `v1.5.4`. The release notes have link like `https://github.com/facebook/zstd/releases/download/v{ARROW_ZSTD_BUILD_VERSION}/zstd-{ARROW_ZSTD_BUILD_VERSION}.tar.gz`. Note that `{ARROW_ZSTD_BUILD_VERSION}` is like `1.5.2` or `1.5.4` without `v`. Here I have 2 solving ways: 1. Just use "github.com/facebook/zstd/archive/", and recount a sha256sum 2. Use "https://github.com/facebook/zstd/releases/download/";, and use `https://github.com/facebook/zstd/releases/download/{ARROW_ZSTD_BUILD_VERSION}/zstd-{remove_prefix(ARROW_ZSTD_BUILD_VERSION)}.tar.gz` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
