tustvold commented on code in PR #3687:
URL: https://github.com/apache/arrow-rs/pull/3687#discussion_r1102621782
##########
arrow/src/ffi.rs:
##########
@@ -827,7 +423,7 @@ pub struct ArrowArray {
pub struct ArrowArrayChild<'a> {
array: &'a FFI_ArrowArray,
schema: &'a FFI_ArrowSchema,
- owner: Arc<FFI_ArrowArray>,
+ owner: &'a Arc<FFI_ArrowArray>,
Review Comment:
This just avoids an unnecessary clone
##########
arrow/src/ffi.rs:
##########
@@ -1526,24 +1108,6 @@ mod tests {
Ok(())
}
- #[test]
- fn null_array_n_buffers() -> Result<()> {
Review Comment:
Moved to arrow-data
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
